Support specifying multiple directories through SSL_CERT_DIR. #92920
+157
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
This was referenced Oct 3, 2023
tmds
force-pushed
the
ssl_cert_dir_multiple
branch
from
a6280dd to
d26becd
Compare
5 tasks
bartonjs
reviewed
Oct 4, 2023
...graphy/src/System/Security/Cryptography/X509Certificates/OpenSslCachedSystemStoreProvider.cs
Outdated
Show resolved
Hide resolved
vcsjones
reviewed
Oct 4, 2023
src/libraries/System.Security.Cryptography/tests/X509Certificates/X509StoreTests.Unix.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jeremy Barton <[email protected]> Co-authored-by: Kevin Jones <[email protected]>
vcsjones
reviewed
Oct 10, 2023
...graphy/src/System/Security/Cryptography/X509Certificates/OpenSslCachedSystemStoreProvider.cs
Show resolved
Hide resolved
...graphy/src/System/Security/Cryptography/X509Certificates/OpenSslCachedSystemStoreProvider.cs
Show resolved
Hide resolved
...graphy/src/System/Security/Cryptography/X509Certificates/OpenSslCachedSystemStoreProvider.cs
Outdated
Show resolved
Hide resolved
bartonjs
approved these changes
Oct 11, 2023
vcsjones
approved these changes
Oct 11, 2023
|
@bartonjs @vcsjones we are backporting this feature into the RHEL .NET 8 builds (more specific: distros that derive of CentOS Stream). We try to avoid having patches that introduce a difference in behavior with upstream .NET. Can you consider backporting this change to the runtime 8.0 branch for inclusion in a 8.0 patch release? |
|
cc @jeffhandley for backport request to .NET 8. |
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6578657107 |
ghost
locked as resolved and limited conversation to collaborators
bartonjs
added
cryptographic-docs-impact
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91110.
@bartonjs @vcsjones ptal.